Sandro Bonazzola has uploaded a new change for review.

Change subject: packaging: setup: iSCSI: fix Host ID validation
......................................................................

packaging: setup: iSCSI: fix Host ID validation

for iSCSI support on additional host, the storage pool
has to be started while validating Host ID in order to
populate /rhev.

Change-Id: Ia3185bb20cbdfb128c529c35d2cc33b1879b5f29
Bug-Url: https://bugzilla.redhat.com/1099882
Signed-off-by: Sandro Bonazzola <sbona...@redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 8 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-hosted-engine-setup 
refs/changes/91/27991/1

diff --git a/src/plugins/ovirt-hosted-engine-setup/storage/storage.py 
b/src/plugins/ovirt-hosted-engine-setup/storage/storage.py
index 85927c8..f18f9ae 100644
--- a/src/plugins/ovirt-hosted-engine-setup/storage/storage.py
+++ b/src/plugins/ovirt-hosted-engine-setup/storage/storage.py
@@ -162,6 +162,12 @@
                                 _('Cannot use the same ID used by first host')
                             )
                     # ensure nobody else is using it
+                    if self.storageType in (
+                        ohostedcons.VDSMConstants.ISCSI_DOMAIN,
+                    ):
+                        # For iSCSI we need to connect the pool for
+                        # having /rhev populated.
+                        self._storagePoolConnection()
                     all_host_stats = {}
                     with ohostedutil.VirtUserContext(
                         environment=self.environment,
@@ -237,7 +243,6 @@
                         ohostedcons.StorageEnv.SD_UUID
                     ]
                 )
-                self._handleHostId()
                 pool_list = domain_info['pool']
                 if pool_list:
                     self.pool_exists = True
@@ -245,7 +250,8 @@
                     self.environment[
                         ohostedcons.StorageEnv.SP_UUID
                     ] = spUUID
-                    self._storagePoolConnection()
+                self._handleHostId()
+                if self.pool_exists:
                     pool_info = self._getStoragePoolInfo(spUUID)
                     if pool_info:
                         self.environment[


-- 
To view, visit http://gerrit.ovirt.org/27991
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3185bb20cbdfb128c529c35d2cc33b1879b5f29
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to