anmolbabu has posted comments on this change. Change subject: engine : Introduce TimeConverter ......................................................................
Patch Set 16: (1 comment) http://gerrit.ovirt.org/#/c/27469/16/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/TimeConverterTest.java File backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/TimeConverterTest.java: Line 11: public void testConvertSecondsToMinutes() { Line 12: long seconds = 1800L; Line 13: Pair<Long, TimeUnit> expectedResults = TimeConverter.autoConvert(seconds, TimeUnit.SECONDS); Line 14: assertEquals(expectedResults.getFirst().longValue() , 30L); Line 15: assertEquals(expectedResults.getSecond(), TimeUnit.MINUTES); > Reorder expected and actual as per this patch - http://gerrit.ovirt.org/#/c Done Line 16: } Line 17: Line 18: @Test Line 19: public void testConvertMinutesToHours() { -- To view, visit http://gerrit.ovirt.org/27469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I045aaa4f93b345e0457e1a0ce2ccf0ceeb9071ad Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
