Sahina Bose has posted comments on this change. Change subject: engine: TimeConversions in GlusterVolumeProfileInfoReturnForXmlRpc ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/27945/10/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeProfileInfoReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumeProfileInfoReturnForXmlRpc.java: Line 116: private StatsInfo getStatInfo(Map<String, Object> statsInfoMap, String statType) { Line 117: StatsInfo statsInfo = new StatsInfo(); Line 118: int statsDuration = Integer.valueOf((String) statsInfoMap.get(DURATION)); Line 119: Pair<Long, TimeUnit> statsDurationFormatted = TimeConverter.autoConvert(statsDuration, TimeUnit.SECONDS); Line 120: statsInfo.setDurationFormatted(new Pair<Integer, String>(statsDurationFormatted.getFirst().intValue(), statsDurationFormatted.getSecond().toString())); What about setDuration? Line 121: statsInfo.setTotalWrite(Long.valueOf((String) statsInfoMap.get(TOTAL_WRITE))); Line 122: statsInfo.setTotalRead(Long.valueOf((String) statsInfoMap.get(TOTAL_READ))); Line 123: statsInfo.setBlockStats(getBlockStats((Object[]) statsInfoMap.get(BLOCK_STATS))); Line 124: statsInfo.setFopStats(getFopStats((Object[]) statsInfoMap.get(FOP_STATS))); -- To view, visit http://gerrit.ovirt.org/27945 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19065777b2cdd2b592677769ac23512f2c36b3d3 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
