Moti Asayag has posted comments on this change. Change subject: engine: Simplify code in UpdateVdsGroupCommand ......................................................................
Patch Set 2: Code-Review+1 There can-do-action prevents a case of changing a cluster between data-centers. The only valid use-case is moving a cluster with no data-center (i.e. when a dc was forcibly removed) to an existing data-center. Eli, Yair, could you think on other use-case that might be risked by this patch ? -- To view, visit http://gerrit.ovirt.org/27831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0091d9afb6d4b26c4ba9fb434192a56eda9397e4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
