Oved Ourfali has posted comments on this change.

Change subject: core:  [RFE] Restart HA VMs ASAP
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/27985/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SshSoftFencingCommand.java:

Line 39:             return;
Line 40:         }
Line 41:         if (isPmReportsStatusDown()) {
Line 42:             // do not try to soft-fence if Host is reported as Down 
via PM
Line 43:             getReturnValue().setSucceeded(false);
in that case do we want to return "false"?
Line 44:         }
Line 45:         else {
Line 46:             VdsValidator validator = new VdsValidator(getVds());
Line 47:             if (validator.shouldVdsBeFenced()) {


-- 
To view, visit http://gerrit.ovirt.org/27985
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaca0111d13a625014fb424bdccd3709b8ea03382
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to