anmolbabu has posted comments on this change.

Change subject: engine: TimeConversions in 
GlusterVolumeProfileInfoReturnForXmlRpc
......................................................................


Patch Set 4: -Verified

(1 comment)

http://gerrit.ovirt.org/#/c/27945/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/FopStats.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/FopStats.java:

Line 6: 
Line 7:     private static final long serialVersionUID = 3705558577202227092L;
Line 8:     private String name;
Line 9:     private int hits;
Line 10:     private double avgLatency;
> Can we think of using Pair for maintaining the latency and its unit ??
Done
Line 11:     private String avgLatencyUnit;
Line 12:     private double minLatency;
Line 13:     private String minLatencyUnit;
Line 14:     private double maxLatency;


-- 
To view, visit http://gerrit.ovirt.org/27945
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19065777b2cdd2b592677769ac23512f2c36b3d3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to