Martin Mucha has posted comments on this change. Change subject: core: macPool per DC, db changes ......................................................................
Patch Set 16: (1 comment) altered answer: I have to use macPoolId on StoragePool only — I'd have to alter SearchQuery and that's not easy/cheap/possible. (probably all 3). http://gerrit.ovirt.org/#/c/26795/16/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java: Line 50: Line 51: private QuotaEnforcementTypeEnum quotaEnforcementType; Line 52: Line 53: @NotNull(groups = {CreateEntity.class, UpdateEntity.class}) Line 54: private MacPool macPool; > a) isn't this a premature optimization? :) You was right. I just saw SearchQuery insanity. I do not have enough courage even to watch initQueryData method. And I would have to modify it, so that's not the right way. I change this field to Long macPoolId, and fire successive queries where needed. Line 55: Line 56: public StoragePool() { Line 57: id = Guid.Empty; Line 58: status = StoragePoolStatus.Uninitialized; -- To view, visit http://gerrit.ovirt.org/26795 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id30f3c384ecf933daaacdbdd6542e88afb98f7ca Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
