Shubhendu Tripathi has posted comments on this change. Change subject: engine : Introduce TimeConverter ......................................................................
Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/27469/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/TimeConverter.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/TimeConverter.java: Line 23: })); Line 24: } Line 25: Line 26: public static long convert(long interval, TimeUnit inUnit, TimeUnit toUnit) { Line 27: return TimeUnit.valueOf(toUnit.name()).convert(interval, inUnit); %s/inUnit/fromUnit/g ??? Line 28: } Line 29: Line 30: public static Pair<Long, TimeUnit> autoConvert(long interval, TimeUnit inUnit) { Line 31: init(); http://gerrit.ovirt.org/#/c/27469/11/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/TimeConverterTest.java File backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/TimeConverterTest.java: Line 1: package org.ovirt.engine.core.common.utils; No test cases for convert method ?? Line 2: Line 3: import static org.junit.Assert.assertEquals; Line 4: Line 5: import java.util.concurrent.TimeUnit; -- To view, visit http://gerrit.ovirt.org/27469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I045aaa4f93b345e0457e1a0ce2ccf0ceeb9071ad Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
