Omer Frenkel has posted comments on this change. Change subject: core: remove duplicated custom properties handling ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27883/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java: Line 891: vmStatic.setCreatedByUserId(getUserId()); Line 892: // Parses the custom properties field that was filled by frontend to Line 893: // predefined and user defined fields Line 894: VmPropertiesUtils.getInstance().separeteCustomPropertiesToUserAndPredefined( Line 895: ClusterUtils.getCompatibilityVersion(getParameters().getVm()), no need to work hard, im pretty sure cluster already cached in the command and you can just go with getVdsGroup() Line 896: vmStatic); Line 897: Line 898: updateOriginalTemplate(vmStatic); Line 899: -- To view, visit http://gerrit.ovirt.org/27883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c37a001985da09cbb7e3f78db1e419901d532cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
