Yair Zaslavsky has posted comments on this change. Change subject: aaa: Extensions tester tool ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/27814/7/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/ExtensionsTool.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/ExtensionsTool.java: Line 70: System.out.print("Please enter user: "); Line 71: user = System.console().readLine(); Line 72: } Line 73: Line 74: if (args.contains(ExtensionsToolArguments.ARG_PASSWORD_ENV_KEY)) { > startswith? args is not a string. Line 75: password = System.getenv(args.get(ExtensionsToolArguments.ARG_PASSWORD_ENV_KEY)); Line 76: } else if (args.contains(ExtensionsToolArguments.ARG_PASSWORD_FILE)) { Line 77: try (BufferedReader reader = new BufferedReader(new InputStreamReader( new FileInputStream(args.get(ExtensionsToolArguments.ARG_PASSWORD_FILE))))) { Line 78: password = reader.readLine(); http://gerrit.ovirt.org/#/c/27814/7/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/ExtensionsToolArguments.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/ExtensionsToolArguments.java: Line 29: // Auth arguments Line 30: public static final String ARG_USER = "--user"; Line 31: public static final String ARG_AUTHN_NAME = "--authn"; Line 32: public static final String ARG_PASSWORD_FILE = "--password-file"; Line 33: public static final String ARG_PASSWORD_ENV_KEY = "--password-env-key"; > please use the env: file: pass: prefixes of password value and have single Done Line 34: Line 35: // Query arguments Line 36: public static final String ARG_AUTHZ_NAME = "--authz"; Line 37: public static final String ARG_QUERY_ENTITY = "--query-entity"; -- To view, visit http://gerrit.ovirt.org/27814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
