Greg Sheremeta has posted comments on this change.

Change subject: webadmin: fixed edit icons in Setup Host Network dialog pt 2
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/27891/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java:

Line 74:             }
Line 75:         });
Line 76:         actionButton.getDownFace().setImage(new 
Image(resources.editMouseDown()));
Line 77:         actionButton.setPixelSize(editImage.getWidth(), 
editImage.getHeight());
Line 78:         actionButton.setStyleName(style.actionButtonNetwork());
> This is indeed the right fix, but I would put it in NicPanel instead; here 
Done
Line 79:         actionButton.setVisible(false);
Line 80: 
Line 81:         this.item = item;
Line 82:         this.style = style;


-- 
To view, visit http://gerrit.ovirt.org/27891
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb45622db8cf5bed3010fe7d215c89c40fa7df01
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to