Arik Hadas has posted comments on this change. Change subject: core: Adding import of unregistered VM template ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/27581/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java: Line 156: getVmTemplate().setDiskImageMap(imageMap); Line 157: } Line 158: } Line 159: Line 160: if (retVal && getParameters().isImportAsNewEntity()) { > no because we might want to import the VM as a new entity if it is already VM -> template, right? because you block import of VM as new entity (import as new requires copy collapse, but copy collapse is not allowed for unregistered VM), so we should be consistent - either block it for templates as well or permit it for VMs (is there a reason to block copy-collapse for unregistered VMs?) Line 161: initImportClonedTemplate(); Line 162: } Line 163: Line 164: if (retVal) { -- To view, visit http://gerrit.ovirt.org/27581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4fc184e687cbeebf4aa732c901f98222d5b11097 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
