Shirly Radco has uploaded a new change for review.
Change subject: reports: dr2 report - added comments to queries
......................................................................
reports: dr2 report - added comments to queries
Changed the code structure so it will be more readable
and added commets.
Change-Id: I7435ab09c14b50a4f24f8016b0829a4b76ca822c
Signed-off-by: Shirly Radco <sra...@redhat.com>
---
M
packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/jrxmls/dc_entities_counts_list_dr2_jrxml.data
1 file changed, 13 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-reports refs/changes/29/27929/1
diff --git
a/packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/jrxmls/dc_entities_counts_list_dr2_jrxml.data
b/packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/jrxmls/dc_entities_counts_list_dr2_jrxml.data
index bfb19c8..30be332 100644
---
a/packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/jrxmls/dc_entities_counts_list_dr2_jrxml.data
+++
b/packaging/ovirt-reports/resources/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/jrxmls/dc_entities_counts_list_dr2_jrxml.data
@@ -7,13 +7,20 @@
<property name="ireport.jasperserver.url"
value="http://localhost:8080/jasperserver-pro/"/>
<property name="ireport.jasperserver.report.resource"
value="/reports_resources/embedded_reports/webadmin_dashboards/dc_dashboard/jrxmls/dc_entities_counts_list_dr2_jrxml"/>
<subDataset name="storage_count"
uuid="6b400e6b-94db-4d9e-af5e-48b1d52f3ad3">
- <parameter name="P_DataCenter_ID" class="java.lang.String">
-
<defaultValueExpression><![CDATA[]]></defaultValueExpression>
- </parameter>
- <queryString>
- <![CDATA[SELECT count(DISTINCT
v3_5_latest_map_datacenters_storage_domains.storage_domain_id) AS storage_count
+ <parameter name="P_DataCenter_ID" class="java.lang.String"/>
+ <queryString language="SQL">
+ <![CDATA[-- DR2- This query returns the total count of
storage domains
+-- for the chosen datacenter.
+
+SELECT
+ COUNT (
+ DISTINCT v3_5_latest_map_datacenters_storage_domains.storage_domain_id
+ ) AS storage_count
FROM v3_5_latest_map_datacenters_storage_domains
-WHERE v3_5_latest_map_datacenters_storage_domains.datacenter_id =
CAST($P{P_DataCenter_ID} as UUID)]]>
+WHERE
+ -- Here we filter by the datacenter chosen by the user
+ v3_5_latest_map_datacenters_storage_domains.datacenter_id =
+ CAST ( $P{P_DataCenter_ID} as UUID )]]>
</queryString>
<field name="storage_count" class="java.lang.Long"/>
</subDataset>
--
To view, visit http://gerrit.ovirt.org/27929
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7435ab09c14b50a4f24f8016b0829a4b76ca822c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sra...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
