Ramesh N has uploaded a new change for review. Change subject: gluster:Hide skipped file count in remove brick status ......................................................................
gluster:Hide skipped file count in remove brick status Skipped file count will be always zero in remove brick status and it can be removed from remove-brick status dialog. Change-Id: Iefaea9d3bfab34e405386e70f18277b488c10cc2 Bug-Url: https://bugzilla.redhat.com/1064712 Signed-off-by: Ramesh Nachimuthu <rnach...@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/RemoveBrickStatusPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java 2 files changed, 16 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/28/27928/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/RemoveBrickStatusPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/RemoveBrickStatusPopupView.java index 2d525f4..b53be9a 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/RemoveBrickStatusPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/RemoveBrickStatusPopupView.java @@ -23,4 +23,8 @@ return constants.filesMigrated(); } + @Override + public boolean isSkippedFileCountNeeded(){ + return false; + } } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java index 7f8d783..d3deab1 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java @@ -173,12 +173,14 @@ } }, constants.rebalanceFailedFileCount()); - rebalanceHostsTable.addEntityModelColumn(new EntityModelTextColumn<GlusterVolumeTaskStatusForHost>() { - @Override - protected String getText(GlusterVolumeTaskStatusForHost entity) { - return String.valueOf(entity.getFilesSkipped()); - } - }, constants.rebalanceSkippedFileCount()); + if (isSkippedFileCountNeeded()){ + rebalanceHostsTable.addEntityModelColumn(new EntityModelTextColumn<GlusterVolumeTaskStatusForHost>() { + @Override + protected String getText(GlusterVolumeTaskStatusForHost entity) { + return String.valueOf(entity.getFilesSkipped()); + } + }, constants.rebalanceSkippedFileCount()); + } rebalanceHostsTable.addEntityModelColumn(new EntityModelTextColumn<GlusterVolumeTaskStatusForHost>() { @Override @@ -196,6 +198,10 @@ }, constants.rebalanceRunTime()); } + public boolean isSkippedFileCountNeeded(){ + return true; + } + public String getColumnHeaderForFilesMoved() { return constants.rebalanceFileCount(); } -- To view, visit http://gerrit.ovirt.org/27928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iefaea9d3bfab34e405386e70f18277b488c10cc2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
