Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin: click on line in roster doesn't select desired line (#806248) ......................................................................
webadmin: click on line in roster doesn't select desired line (#806248) https://bugzilla.redhat.com/806248 On many places (adding users, host-networks, etc) in webadmin has to be chosen check-box precisely. During mouse hover above line is that line properly coloured, but nothing happened when user want to click on it. There where two different widgets which had to be enriched by this behaviour: 1: EntityModelCellTable - responsible for adding new users. It has been solved by adding a CellPreviewHandler to the EntityModelCellTable which notifies the selection model that the selection should be changed. The support is implemented only for cases where the hideCheckbox is false, because the opposite scenario is used in special cases where the selection does not necessarily make sense (e.g. table headers, trees etc.). 2: HostInterfaceForm and it's panels - responsible for configuring network interfaces. It has been solved by adding click handler to the specific panels (InterfacePanel, BondPanel and VLanPanel) which which updates the model according to the selection. The TogglePanel than listens to this change event and updates the row coloring accordingly. Change-Id: I1b485e70e6319084f1764aeb72287ccb84cce511 Signed-off-by: Tomas Jelinek <tjeli...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ModelBoundCheckBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/TogglePanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/HostInterfaceForm.java 4 files changed, 57 insertions(+), 12 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b485e70e6319084f1764aeb72287ccb84cce511 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
