Allon Mureinik has posted comments on this change. Change subject: core: send domains map on connectStoragePool ......................................................................
Patch Set 10: Verified-1 Code-Review+1 (2 comments) The concept looks OK, aside from the fact it doesn't compile :-) http://gerrit.ovirt.org/#/c/22712/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperation.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RefreshStoragePoolAndDisconnectAsyncOperation.java: Line 16: public class RefreshStoragePoolAndDisconnectAsyncOperation extends ActivateDeactivateSingleAsyncOperation { Line 17: Line 18: private Guid masterStorageDomainId; Line 19: Line 20: private List<StoragePoolIsoMap> storagePoolIsoMap; You're missing an import of java.util.List - the code won't compile. Line 21: Line 22: public RefreshStoragePoolAndDisconnectAsyncOperation(ArrayList<VDS> vdss, StorageDomain domain, Line 23: StoragePool storagePool) { Line 24: super(vdss, domain, storagePool); http://gerrit.ovirt.org/#/c/22712/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java: Line 133: } Line 134: } Line 135: Line 136: List<Guid> vdsIdsToSetNonOperational = new ArrayList<Guid>(); Line 137: runSynchronizeOperation(new RefreshPoolSingleAsyncOperationFactory(), vdsIdsToSetNonOperational); I'd inline the new ArrayList<Guid>() call. Line 138: } Line 139: Line 140: private void updateMemberDomainsFormat(StorageFormatType targetFormat) { Line 141: Guid spId = getStoragePool().getId(); -- To view, visit http://gerrit.ovirt.org/22712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16034c6757959e5d0445814a8acc2221a74f6aa Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
