Yair Zaslavsky has posted comments on this change. Change subject: aaa: Extensions tester tool ......................................................................
Patch Set 6: (4 comments) http://gerrit.ovirt.org/#/c/27814/6/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/ExtensionsTool.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/ExtensionsTool.java: Line 13: import org.ovirt.engine.api.extensions.ExtMap; Line 14: import org.ovirt.engine.api.extensions.ExtUUID; Line 15: import org.ovirt.engine.api.extensions.aaa.Authn; Line 16: import org.ovirt.engine.api.extensions.aaa.Authz; Line 17: import org.ovirt.engine.core.aaa.SearchQueryParsingUtils; > now think that this component is a different project written by different p I understand, still, this is quite a shame :( I will fix. Line 18: import org.ovirt.engine.core.extensions.mgr.ExtensionProxy; Line 19: import org.ovirt.engine.core.extensions.mgr.ExtensionsManager; Line 20: Line 21: public class ExtensionsTool { Line 286: log.info(String.format("AuthRecord: Principal %s, ValidTo: %s", Line 287: extMap.get(Authn.AuthRecord.PRINCIPAL, ""), Line 288: extMap.get(Authn.AuthRecord.VALID_TO, ""))); Line 289: } Line 290: } > please add debug mode to dump the entire in/out, or add debug mode to enabl i will add to the trace log. Line 291: http://gerrit.ovirt.org/#/c/27814/6/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/ExtensionsToolExecutor.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/ExtensionsToolExecutor.java: Line 18: public static void setupLogging(String log4jConfig, String logFile, String logLevel) { Line 19: URL cfgFileUrl = null; Line 20: try { Line 21: if (log4jConfig == null) { Line 22: cfgFileUrl = ExtensionsToolExecutor.class.getResource("/extensions-tool/log4j.xml"); > already replied there. ok, i will take care of that, and anyway, we would like to work with java util logging, this is different configuration. Line 23: } else { Line 24: cfgFileUrl = new File(log4jConfig).toURI().toURL(); Line 25: } Line 26: Log4jUtils.setupLogging(cfgFileUrl); http://gerrit.ovirt.org/#/c/27814/6/backend/manager/tools/src/main/resources/extensions-tester/jaas.conf File backend/manager/tools/src/main/resources/extensions-tester/jaas.conf: Line 1 Line 2 Line 3 Line 4 > squash into previous? As we discussed, no need for this one, we should have only one jaas file. -- To view, visit http://gerrit.ovirt.org/27814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ea2f9c62ced5bdd3801c9f6d8087a35e3c21886 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
