Alona Kaplan has posted comments on this change. Change subject: engine: Adding GetInterfacesAttachedToNetworkViaLabelQuery ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/27803/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetInterfacesAttachedToNetworkViaLabelQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetInterfacesAttachedToNetworkViaLabelQuery.java: Line 11: import org.ovirt.engine.core.common.businessentities.network.VdsNetworkInterface; Line 12: import org.ovirt.engine.core.common.queries.IdQueryParameters; Line 13: import org.ovirt.engine.core.utils.NetworkUtils; Line 14: Line 15: public class GetInterfacesAttachedToNetworkViaLabelQuery<P extends IdQueryParameters> extends QueriesCommandBase<P> { > GetInterfacesByLabelForNetworkQuery ? Done Line 16: public GetInterfacesAttachedToNetworkViaLabelQuery(P parameters) { Line 17: super(parameters); Line 18: } Line 19: Line 29: Line 30: List<VdsNetworkInterface> networkNics = Line 31: getDbFacade().getInterfaceDao().getVdsInterfacesByNetworkId(network.getId()); Line 32: Map<String, VdsNetworkInterface> labelNicsByName = Entities.entitiesByName(labeledNics); Line 33: List<VdsNetworkInterface> returnList = new ArrayList<>(); > And a Set will serve you better than a List, won't it? Done Line 34: Line 35: for (VdsNetworkInterface networkNic : networkNics) { Line 36: if (labelNicsByName.containsKey(NetworkUtils.stripVlan(networkNic))) { Line 37: returnList.add(networkNic); Line 29: Line 30: List<VdsNetworkInterface> networkNics = Line 31: getDbFacade().getInterfaceDao().getVdsInterfacesByNetworkId(network.getId()); Line 32: Map<String, VdsNetworkInterface> labelNicsByName = Entities.entitiesByName(labeledNics); Line 33: List<VdsNetworkInterface> returnList = new ArrayList<>(); > please select a meaningful name instead of returnList Done Line 34: Line 35: for (VdsNetworkInterface networkNic : networkNics) { Line 36: if (labelNicsByName.containsKey(NetworkUtils.stripVlan(networkNic))) { Line 37: returnList.add(networkNic); -- To view, visit http://gerrit.ovirt.org/27803 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5701455e2b372e4b656c87e05781fe05a95f9f0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
