Alona Kaplan has posted comments on this change. Change subject: webadmin: adding labels column to Network->Hosts sub-tab ......................................................................
Patch Set 12: (2 comments) http://gerrit.ovirt.org/#/c/24992/12/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkHostListModel.java: Line 70: @Override Line 71: public void onSuccess(final Object model, Object ReturnValue) { Line 72: if (model.equals(getViewFilterType())) { Line 73: final Iterable returnList = (Iterable) ((VdcQueryReturnValue) ReturnValue).getReturnValue(); Line 74: final List<PairQueryable<VdsNetworkInterface, VDS>> items = > This is only relevant to the unattached case, so I would put it inside the Done Line 75: new ArrayList<PairQueryable<VdsNetworkInterface, VDS>>(); Line 76: if (NetworkHostFilter.unattached.equals(getViewFilterType())) { Line 77: for (Object obj : returnList) { Line 78: items.add(new PairQueryable<VdsNetworkInterface, VDS>(null, (VDS) obj)); Line 96: Line 97: setIsQueryFirstTime(false); Line 98: } Line 99: Line 100: private void initAttachedByLabelInterfaces(final List<PairQueryable<VdsNetworkInterface, VDS>> items) { > Maybe name it so that it's clearer setItems() is called as a result of this Done Line 101: if (StringUtils.isEmpty(getEntity().getLabel())) { Line 102: setItems(items); Line 103: return; Line 104: } -- To view, visit http://gerrit.ovirt.org/24992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I610703df29dcae7ace390e0ebb109475fb202263 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
