Dima Kuznetsov has posted comments on this change. Change subject: webadmin: Move CPU info to HW info tab ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/27255/7//COMMIT_MSG Commit Message: Line 9: Moved CPU related labels out of Host-General to Host-Hardware Line 10: Information sub-tab. The Host-General sub-tab was getting full and I Line 11: have another patch that introduced a new label that should be put there. Line 12: Line 13: I've added a new label called to Host-General, "Logical CPU Cores" that > "called" can be removed, or rephrase.. :) Done Line 14: displays the total cores available to the host. This freed up 4 slots on Line 15: Host-General tab. Line 16: Line 17: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=894084 Line 10: Information sub-tab. The Host-General sub-tab was getting full and I Line 11: have another patch that introduced a new label that should be put there. Line 12: Line 13: I've added a new label called to Host-General, "Logical CPU Cores" that Line 14: displays the total cores available to the host. This freed up 4 slots on > can you specify which slots? Done Line 15: Host-General tab. Line 16: Line 17: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=894084 Line 18: Change-Id: I9e44c8ddb9b144cc322a7ea7772cf99cdf4807fc http://gerrit.ovirt.org/#/c/27255/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java: Line 945: } Line 946: Line 947: if (vds.getVdsGroupCompatibilityVersion() != null Line 948: && Version.v3_2.compareTo(vds.getVdsGroupCompatibilityVersion()) > 0) { Line 949: setLogicalCores(vds.getCpuCores()); > is it equivalent to "(sockets) * (cores per socket) * (threads per core" ? This is equivalent to (sockets)*(cores per socket) because it appears that multiple threads per core are not supported pre-3.2 clusters, here is a comment for code that set (threads per core) label in pre 3.2 clusters: // Members of pre-3.2 clusters don't support SMT; here we act like a 3.1 engine setThreadsPerCore(constants.unsupported()); Line 950: } else { Line 951: setLogicalCores(vds.getCpuThreads()); Line 952: } Line 953: } -- To view, visit http://gerrit.ovirt.org/27255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e44c8ddb9b144cc322a7ea7772cf99cdf4807fc Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
