Yair Zaslavsky has posted comments on this change. Change subject: aaa: Changes to ExtensionsManager ......................................................................
Patch Set 17: (5 comments) http://gerrit.ovirt.org/#/c/27785/17/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 119 Line 120 Line 121 Line 122 Line 123 > maybe this should be concurrent map now Done Line 228: ); Line 229: } catch (Exception e) { Line 230: throw new RuntimeException(String.format("Error loading extension %1$s", entry.name)); Line 231: } Line 232: loadedEntries.put(entry.name, entry); > use concurrent and put if absent or syncrhonize the entire load? Done Line 233: setChanged(); Line 234: notifyObservers(); Line 235: return entry.name; Line 236: } Line 244: } Line 245: Line 246: public ExtensionProxy activate(String extensionName) { Line 247: ExtensionEntry entry = loadedEntries.get(extensionName); Line 248: if (entry != null && entry.enabled) { > if not found why not raise an exception? i dont htink load and activate should have synchronized in the signature. please comment on the next iteration if still needed to be fixed - as far as I see, even with the split to LOAD and INITIALIZE, all i need is to sync the extensions list of the global context. Line 249: entry.extension.getContext().put( Line 250: TRACE_LOG_CONTEXT_KEY, Line 251: LoggerFactory.getLogger( Line 252: String.format( http://gerrit.ovirt.org/#/c/27785/17/backend/manager/modules/extensions-manager/src/main/modules/org/ovirt/engine/core/extensions-manager/main/module.xml File backend/manager/modules/extensions-manager/src/main/modules/org/ovirt/engine/core/extensions-manager/main/module.xml: Line 11: <module name="javax.servlet.api"/> Line 12: <module name="org.apache.commons.lang"/> Line 13: <module name="org.jboss.modules"/> Line 14: <module name="org.ovirt.engine.api.ovirt-engine-extensions-api"/> Line 15: <module name="org.ovirt.engine.core.utils"/> > no need. i'll fix. Done Line 16: <module name="org.slf4j"/> Line 17: </dependencies> Line 18: http://gerrit.ovirt.org/#/c/27785/17/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/extensionsmgr/EngineExtensionsManager.java: Line 80: } Line 81: Line 82: public void addObserver(Observer observer) { Line 83: instance.addObserver(observer); Line 84: } > which one? sorry, didn't understand. Done Line 85: Line 86: private static void createInternalAAAConfigurations() { Line 87: Properties authConfig = new Properties(); Line 88: authConfig.put(Base.ConfigKeys.NAME, "builtin-authn-internal"); -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
