Ori Liel has posted comments on this change. Change subject: REST: Add calls for queries to get unregistered entities. ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/27628/5/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplatesResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplatesResource.java: Line 43: Template vmTemplate = map(entity); Line 44: collection.add(addLinks(populate(vmTemplate, entity))); Line 45: } Line 46: templates.getTemplates().addAll(collection); Line 47: } same comment as in equivalent VM object. Line 48: Line 49: templates.getTemplates().addAll(getCollection()); Line 50: return templates; Line 51: } http://gerrit.ovirt.org/#/c/27628/5/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmsResource.java: Line 40: VM vm = map(entity); Line 41: collection.add(addLinks(populate(vm, entity))); Line 42: } Line 43: vms.getVMs().addAll(collection); Line 44: } If [GET .../api/storagedomains/xxx/vms;unregistered] shows both registered and unregistered VMs (as is implemented here) I think that the URL parameter should be named: 'include_unregistered'. Line 45: vms.getVMs().addAll(getCollection()); Line 46: return vms; Line 47: } Line 48: -- To view, visit http://gerrit.ovirt.org/27628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7adacfabe640fba6b0ae1a77d27cbe03c28edd37 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
