Yaniv Dary has posted comments on this change. Change subject: reports: br10a report - added comments to queries ......................................................................
Patch Set 1: (8 comments) http://gerrit.ovirt.org/#/c/27802/1/packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_over_time_BR10A_files/single_vm_resources_over_time_BR10A_jrxml.data File packaging/ovirt-reports/resources/Reports/Trend/Virtual_machines/single_vm_resources_over_time_BR10A_files/single_vm_resources_over_time_BR10A_jrxml.data: Line 95: THEN '00000000-0000-0000-0000-000000000000' Line 96: WHEN '11111111-1111-1111-1111-111111111111' Line 97: THEN '00000000-0000-0000-0000-000000000000' Line 98: ELSE CAST ( $P{P_VM_ID} AS uuid ) Line 99: END need to be indented by one more tab Line 100: AND history_datetime >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 101: AND history_datetime < Line 102: CASE Line 103: WHEN $P{P_Period} = 0 Line 258: SELECT device_id Line 259: FROM v3_5_configuration_history_vms_devices Line 260: -- Here we filter by the vm chosen by the user Line 261: WHERE vm_id = Line 262: CASE $P{P_VM_ID} This should be indented by one more tab Line 263: WHEN '00000000-0000-0000-0000-000000000000' Line 264: THEN '00000000-0000-0000-0000-000000000000' Line 265: WHEN NULL Line 266: THEN '00000000-0000-0000-0000-000000000000' Line 268: THEN '00000000-0000-0000-0000-000000000000' Line 269: ELSE CAST ( $P{P_VM_ID} AS uuid ) Line 270: END Line 271: AND create_date < Line 272: CASE also Line 273: WHEN $P{P_Period} = 0 Line 274: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 275: WHEN $P{P_Period} = 1 Line 276: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 month' Line 315: ) Line 316: -- Here we filter deleted vm_disks according to what the user chose Line 317: $P!{is_deleted} Line 318: GROUP BY c.vm_disk_id Line 319: -- Here we sort by the disks that have the max read and write rate. trailing whitespace Line 320: ORDER BY Line 321: MAX ( Line 322: ROUND ( Line 323: CAST ( Line 497: THEN '00000000-0000-0000-0000-000000000000' Line 498: WHEN '11111111-1111-1111-1111-111111111111' Line 499: THEN '00000000-0000-0000-0000-000000000000' Line 500: ELSE CAST ( $P{P_VM_ID} AS uuid ) Line 501: END also Line 502: AND create_date < Line 503: CASE Line 504: WHEN $P{P_Period} = 0 Line 505: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 569: a.time = $P!{calendar_column} Line 570: ) Line 571: WHERE b.$P!{calendar_column} >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 572: AND b.$P!{calendar_column} < Line 573: CASE not a full tab Line 574: WHEN $P{P_Period} = 0 Line 575: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 day' Line 576: WHEN $P{P_Period} = 1 Line 577: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 month' Line 684: THEN '00000000-0000-0000-0000-000000000000' Line 685: WHEN '11111111-1111-1111-1111-111111111111' Line 686: THEN '00000000-0000-0000-0000-000000000000' Line 687: ELSE CAST ( $P{P_VM_ID} AS uuid ) Line 688: END also Line 689: AND history_datetime >= CAST ( $P{P_Start_Date} AS TIMESTAMP ) Line 690: AND history_datetime < Line 691: CASE Line 692: WHEN $P{P_Period} = 0 Line 712: WHEN $P{P_Period} = 2 Line 713: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '3 month' Line 714: WHEN $P{P_Period} = 3 Line 715: THEN CAST ( $P{P_Start_Date} AS TIMESTAMP ) + interval '1 year' Line 716: END also Line 717: GROUP BY Line 718: $P!{calendar_column}, Line 719: CPU_Usage, Line 720: CPU_Peak -- To view, visit http://gerrit.ovirt.org/27802 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9ecd9aa298916a914d10c3774ce597b26466ecf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
