Tomas Jelinek has posted comments on this change. Change subject: restapi: introducing the instance types rest part ......................................................................
Patch Set 4: (9 comments) http://gerrit.ovirt.org/#/c/27776/4/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/InstanceTypesResource.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/InstanceTypesResource.java: Line 29: import javax.ws.rs.Produces; Line 30: import javax.ws.rs.core.Response; Line 31: Line 32: Line 33: @Path("/instance_types") > We don't use underscores in URL segments, use "instancetypes". Done Line 34: @Produces({ApiMediaType.APPLICATION_XML, ApiMediaType.APPLICATION_JSON, ApiMediaType.APPLICATION_X_YAML}) Line 35: public interface InstanceTypesResource { Line 36: Line 37: @GET http://gerrit.ovirt.org/#/c/27776/4/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ApiRootLinksCreator.java: Line 41: links.add(createLink("storagedomains", LinkFlags.SEARCHABLE, baseUri)); Line 42: links.add(createLink("tags", baseUri)); Line 43: links.add(createLink("bookmarks", baseUri)); Line 44: links.add(createLink("templates", LinkFlags.SEARCHABLE, baseUri)); Line 45: links.add(createLink("instance_types", LinkFlags.SEARCHABLE, baseUri)); > Replace with "instancetypes". Done Line 46: links.add(createLink("users", LinkFlags.SEARCHABLE, baseUri)); Line 47: links.add(createLink("groups", LinkFlags.SEARCHABLE, baseUri)); Line 48: links.add(createLink("domains", baseUri)); Line 49: links.add(createLink("vmpools", LinkFlags.SEARCHABLE, baseUri)); http://gerrit.ovirt.org/#/c/27776/4/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 2417: <xs:complexContent> Line 2418: <xs:extension base="Template"> Line 2419: </xs:extension> Line 2420: </xs:complexContent> Line 2421: </xs:complexType> > Fix the indentation: 2 spaces per level. Done Line 2422: Line 2423: <xs:element name="instance_types" type="InstanceTypes"/> Line 2424: <xs:element name="instance_type" type="InstanceType"/> Line 2425: http://gerrit.ovirt.org/#/c/27776/4/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 4878: Content-Type: {value: application/xml|json, required: true} Line 4879: Expect: {value: 201-created, required: false} Line 4880: Correlation-Id: {value: 'any string', required: false} Line 4881: Line 4882: - name: /instance_types|rel=get > No underscores in URL segments, replace with "instancetypes". Done Line 4883: description: get the list of instance types on the system Line 4884: request: Line 4885: body: Line 4886: parameterType: null Line 4887: signatures: [] Line 4888: urlparams: Line 4889: max: {context: matrix, type: 'xs:int', value: 'max results', required: false} Line 4890: headers: {} Line 4891: - name: /instance_types/{instance_type:id}|rel=get > Same: Done - are you sure about the /{instancetype:id} part? I did think that it is the "instance_type" from api.xsd. Or am I wrong? Line 4892: description: get the details of the instance type on the system Line 4893: request: Line 4894: body: Line 4895: parameterType: null Line 4895: parameterType: null Line 4896: signatures: [] Line 4897: urlparams: {} Line 4898: headers: {} Line 4899: - name: /instance_types/{instance_type:id}|rel=delete > Same. Done Line 4900: description: delete the instance type from the system Line 4901: request: Line 4902: body: Line 4903: parameterType: null Line 4905: urlparams: Line 4906: async: {context: matrix, type: 'xs:boolean', value: true|false, required: false} Line 4907: headers: Line 4908: Correlation-Id: {value: 'any string', required: false} Line 4909: - name: /instance_types|rel=add > Same. Done Line 4910: description: add a new instance type to the system Line 4911: request: Line 4912: body: Line 4913: parameterType: InstanceType http://gerrit.ovirt.org/#/c/27776/4/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java: Line 106: "bookmarks", Line 107: "templates", Line 108: "templates/search", Line 109: "instance_types", Line 110: "instance_types/search", > No underscores in URL segments. Done Line 111: "users", Line 112: "users/search", Line 113: "groups", Line 114: "groups/search", Line 163: BASE_PATH + "/bookmarks", Line 164: BASE_PATH + "/templates", Line 165: BASE_PATH + "/templates?search={query}", Line 166: BASE_PATH + "/instance_types", Line 167: BASE_PATH + "/instance_types?search={query}", > Same. Done Line 168: BASE_PATH + "/users", Line 169: BASE_PATH + "/users?search={query}", Line 170: BASE_PATH + "/groups", Line 171: BASE_PATH + "/groups?search={query}", -- To view, visit http://gerrit.ovirt.org/27776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45f464339e30258860f100240f34d1aa51e533ee Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
