Alon Bar-Lev has posted comments on this change. Change subject: aaa: Remove dependency at builtin on Common config ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/27607/8/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/Utils.java: Line 60: if (!krb5File.exists()) { Line 61: throw new Exception(String.format("Failed loading kerberos settings from File %1$s.", Line 62: krb5File.getAbsolutePath())); Line 63: } else { Line 64: System.setProperty("java.security.krb5.conf", krb5File.getAbsolutePath()); > true, and this is a limitation I guess of both the implementation of jaas a me either. so jaas is provided by jboss and tool should provide similar environment, so for plugin there is no change. and the java.security.krb5.conf should be set at engine configuration to be globally available and not set by specific extension, so it can be shared, the tool should provide the same property with the same file. this way we achieve similar environment without damaging anything of the container. Line 65: } Line 66: Configuration.getConfiguration().refresh(); Line 67: DirectoryManager.setObjectFactoryBuilder(new DirectoryContextFactoryBuilder()); Line 68: } -- To view, visit http://gerrit.ovirt.org/27607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1384a99f73ab605b61bce8dcdfd63e222b0001fa Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
