Oved Ourfali has posted comments on this change. Change subject: jsonrpc: Stomp changes in vdsbroker ......................................................................
Patch Set 10: Code-Review+1 (1 comment) minor comment. http://gerrit.ovirt.org/#/c/26783/10/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/TransportFactory.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/TransportFactory.java: Line 13: import org.ovirt.engine.core.vdsbroker.vdsbroker.VdsServerWrapper; Line 14: import org.ovirt.engine.core.vdsbroker.xmlrpc.XmlRpcUtils; Line 15: Line 16: public class TransportFactory { Line 17: public static IIrsServer getIrsServer(VdsProtocol vdsProtocol, String hostname, int port, int clientTimeOut, I'd call it "createIrsServer" instrad of get. Same for the method below. Line 18: int connectionTimeOut, int clientRetries) { Line 19: IIrsServer irsServer = null; Line 20: if (VdsProtocol.STOMP == vdsProtocol) { Line 21: irsServer = new JsonRpcIIrsServer(JsonRpcUtils.createStompClient(hostname, -- To view, visit http://gerrit.ovirt.org/26783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If78de6620ba6891543531ac8ddd633b67828a89c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
