Oved Ourfali has posted comments on this change. Change subject: api: Fix approve API to allow deploy with public key ......................................................................
Patch Set 4: (1 comment) minor comment. http://gerrit.ovirt.org/#/c/27622/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java: Line 136: validateEnums(Action.class, action); Line 137: ApproveVdsParameters params = new ApproveVdsParameters(guid); Line 138: params = (ApproveVdsParameters) getMapper Line 139: (Action.class, VdsOperationActionParameters.class).map(action, (VdsOperationActionParameters) params); Line 140: just create an authentication method varialbe, and set it at the end of this section. (rather than having two else clauses). Line 141: if (action.isSetSsh() && action.getSsh().isSetAuthenticationMethod()) { Line 142: if (action.getSsh().getAuthenticationMethod() == Line 143: VdsOperationActionParameters.AuthenticationMethod.Password.toString()) { Line 144: params.setAuthMethod(VdsOperationActionParameters.AuthenticationMethod.Password); -- To view, visit http://gerrit.ovirt.org/27622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9816d907d45ec7b4ee066fa369ca1150e688084f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
