Alon Bar-Lev has posted comments on this change. Change subject: engine: Json-rpc integration ......................................................................
Patch Set 30: (3 comments) http://gerrit.ovirt.org/#/c/20926/30/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 534: Requires: %{name}-sdk-python >= 3.4.0.7 Line 535: Requires: %{name}-setup-plugin-ovirt-engine = %{version}-%{release} Line 536: Requires: openssh-server Line 537: Requires: ovirt-host-deploy >= 1.1.2-1 Line 538: Requires: ovirt-host-deploy-offline >= 1.1.2-1 above are incorrect change Line 539: Requires: vdsm jsonrpc-java Line 540: Line 541: %description setup-plugin-allinone Line 542: All-in-one plugin for %{ovirt_product_name_short}'s setup http://gerrit.ovirt.org/#/c/20926/30/pom.xml File pom.xml: Line 81 Line 82 Line 83 Line 84 Line 85 you should add sonatype snapshots for now Line 73: <ovirt-host-deploy.version>1.2.0</ovirt-host-deploy.version> Line 74: <org.ovirt.engine.api.ovirt-engine-extensions-api.version>0.0.0-SNAPSHOT</org.ovirt.engine.api.ovirt-engine-extensions-api.version> Line 75: <vdsm-jsonrpc-java.version>1.0.0-master</vdsm-jsonrpc-java.version> Line 76: <slf4j.version>1.7.5</slf4j.version> Line 77: <slf4j-jdk14.version>1.5.6</slf4j-jdk14.version> why do you pull anything of jdk14? Line 78: <gwt.version>2.5.1</gwt.version> Line 79: <findbugs.version>2.5.2</findbugs.version> Line 80: <mockito.version>1.9.0</mockito.version> Line 81: <javassist.version>3.12.0.GA</javassist.version> -- To view, visit http://gerrit.ovirt.org/20926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66ef0c98f07de6c447a5fffc42c9dbc94580df46 Gerrit-PatchSet: 30 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
