Omer Frenkel has posted comments on this change. Change subject: core: add support to update running vm ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/26758/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 556: Line 557: protected boolean areUpdatedFieldsLegal() { Line 558: return VmHandler.isUpdateValid(getVm().getStaticData(), Line 559: getParameters().getVmStaticData(), Line 560: VMStatus.Down); > did you check that the logic in UpdateVmCommandTest where this method is in yes Line 561: } Line 562: Line 563: /** Line 564: * check if we need to use running-configuration -- To view, visit http://gerrit.ovirt.org/26758 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie433352852f53f62e58349ce85475ee89e37ce89 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
