Mike Kolesnik has posted comments on this change. Change subject: core: util for removing overlaps in ranges ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/26403/6/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RangesWithoutOverlapsTest.java File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RangesWithoutOverlapsTest.java: Line 19: Line 20: private Pair<Long, Long>[] inputRanges; Line 21: private final Pair<Long, Long>[] expectedRanges; Line 22: private final Class<? extends Exception> expectedExceptionClass; Line 23: private final String expectedErrorMessage; > JUnit tests are often considered as contract specification. So this JUnit s In that case, please extract message to shared constant to avoid confusion Line 24: Line 25: @Parameterized.Parameters Line 26: public static List<Object[]> parameters() { Line 27: return Arrays.asList(new Object[][]{ -- To view, visit http://gerrit.ovirt.org/26403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7dbacd11b610a5885d574356a695c6e879dcdbc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
