Allon Mureinik has uploaded a new change for review.

Change subject: core: UpdateVmCommandTest remove Arrays.asList
......................................................................

core: UpdateVmCommandTest remove Arrays.asList

Replace single argument Arrays.asList calls with the better performing
Collections.singletonList.

Change-Id: I76b439558ccc2fc9239c0c642ba33db89f0dfda0
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/69/27769/1

diff --git 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
index 33285fd..85516b2 100644
--- 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
+++ 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
@@ -198,7 +198,7 @@
 
         UpdateVmDiskParameters parameters = createParameters();
         parameters.getDiskInfo().setReadOnly(true);
-        initializeCommand(parameters, Arrays.asList(createVm(VMStatus.Up)));
+        initializeCommand(parameters, 
Collections.singletonList(createVm(VMStatus.Up)));
 
         CanDoActionTestUtils.runAndAssertCanDoActionFailure(command, 
VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_NOT_DOWN);
     }
@@ -327,7 +327,7 @@
         UpdateVmDiskParameters parameters = createParameters();
         parameters.getDiskInfo().setReadOnly(false);
         parameters.getDiskInfo().setWipeAfterDelete(true);
-        initializeCommand(parameters, Arrays.asList(createVm(status)));
+        initializeCommand(parameters, 
Collections.singletonList(createVm(status)));
 
         CanDoActionTestUtils.runAndAssertCanDoActionSuccess(command);
     }
@@ -725,7 +725,7 @@
         StorageDomain storage = new StorageDomain();
         storage.setId(Guid.newGuid());
         storage.setStorageType(storageType);
-        diskImage.setStorageIds(new 
ArrayList<>(Arrays.asList(storage.getId())));
+        diskImage.setStorageIds(new 
ArrayList<>(Collections.singletonList(storage.getId())));
         return storage;
     }
 


-- 
To view, visit http://gerrit.ovirt.org/27769
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I76b439558ccc2fc9239c0c642ba33db89f0dfda0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to