[Engine-patches] Change in ovirt-engine[master]: core: GetHostListFromExternalProvider generics

[amureini]

Allon Mureinik has uploaded a new change for review.

Change subject: core: GetHostListFromExternalProvider generics
......................................................................

core: GetHostListFromExternalProvider generics

Use Java 7 style generics to improve readability wherever possible.

Change-Id: Icfeaa553768b7a00437bfcda81e2e6c226bcc59d
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java
1 file changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/27764/1

diff --git 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java
 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java
index 74edf6c..a2771e9 100644
--- 
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java
+++ 
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java
@@ -19,7 +19,7 @@
     private final VDS host2 = new VDS();
     private final VDS existingHost1 = new VDS();
     private final VDS existingHost2 = new VDS();
-    private final Provider hostProvider = new Provider();
+    private final Provider<?> hostProvider = new Provider();
 
     @Before
     @Override
@@ -35,10 +35,10 @@
     public void testAllHosts() {
         when(getQueryParameters().isFilterOutExistingHosts()).thenReturn(true);
         doReturn(hostProvider).when(getQuery()).getProvider();
-        List<VDS> allHosts = new ArrayList<VDS>();
+        List<VDS> allHosts = new ArrayList<>();
         allHosts.add(host1);
         allHosts.add(host2);
-        List<VDS> existingHosts = new ArrayList<VDS>();
+        List<VDS> existingHosts = new ArrayList<>();
         existingHosts.add(existingHost1);
         existingHosts.add(existingHost2);
         doReturn(allHosts).when(getQuery()).getProviderHosts(hostProvider, 
null);
@@ -51,10 +51,10 @@
     public void testHostsContainExistingHosts() {
         when(getQueryParameters().isFilterOutExistingHosts()).thenReturn(true);
         doReturn(hostProvider).when(getQuery()).getProvider();
-        List<VDS> allHosts = new ArrayList<VDS>();
+        List<VDS> allHosts = new ArrayList<>();
         allHosts.add(host1);
         allHosts.add(host2);
-        List<VDS> existingHosts = new ArrayList<VDS>();
+        List<VDS> existingHosts = new ArrayList<>();
         existingHosts.add(host1);
         doReturn(allHosts).when(getQuery()).getProviderHosts(hostProvider, 
null);
         doReturn(existingHosts).when(getQuery()).getExistingHosts();
@@ -66,10 +66,10 @@
     public void testAllHostsNonFiltered() {
         
when(getQueryParameters().isFilterOutExistingHosts()).thenReturn(false);
         doReturn(hostProvider).when(getQuery()).getProvider();
-        List<VDS> allHosts = new ArrayList<VDS>();
+        List<VDS> allHosts = new ArrayList<>();
         allHosts.add(host1);
         allHosts.add(host2);
-        List<VDS> existingHosts = new ArrayList<VDS>();
+        List<VDS> existingHosts = new ArrayList<>();
         existingHosts.add(existingHost1);
         existingHosts.add(existingHost2);
         doReturn(allHosts).when(getQuery()).getProviderHosts(hostProvider, 
null);
@@ -82,10 +82,10 @@
     public void testHostsContainExistingHostsNonFiltered() {
         
when(getQueryParameters().isFilterOutExistingHosts()).thenReturn(false);
         doReturn(hostProvider).when(getQuery()).getProvider();
-        List<VDS> allHosts = new ArrayList<VDS>();
+        List<VDS> allHosts = new ArrayList<>();
         allHosts.add(host1);
         allHosts.add(host2);
-        List<VDS> existingHosts = new ArrayList<VDS>();
+        List<VDS> existingHosts = new ArrayList<>();
         existingHosts.add(host1);
         doReturn(allHosts).when(getQuery()).getProviderHosts(hostProvider, 
null);
         doReturn(existingHosts).when(getQuery()).getExistingHosts();


-- 
To view, visit http://gerrit.ovirt.org/27764
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfeaa553768b7a00437bfcda81e2e6c226bcc59d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches