Allon Mureinik has uploaded a new change for review. Change subject: core: UpdateVmDiskCommandTest generics ......................................................................
core: UpdateVmDiskCommandTest generics Use Java 7 style generics to make the code more readable. Change-Id: Iece81799898b3ec2fdb383418d8d82f7e3e57a1a Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/68/27768/1 diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java index b9f6fa2..33285fd 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java @@ -137,7 +137,7 @@ DiskImage otherDisk = new DiskImage(); otherDisk.setId(Guid.newGuid()); otherDisk.setActive(true); - when(diskDao.getAllForVm(vmId)).thenReturn(new LinkedList<Disk>(Arrays.asList(parameters.getDiskInfo(), + when(diskDao.getAllForVm(vmId)).thenReturn(new LinkedList<>(Arrays.asList(parameters.getDiskInfo(), otherDisk))); when(diskDao.get(diskImageGuid)).thenReturn(createDiskImage()); initializeCommand(parameters); @@ -595,7 +595,7 @@ } protected void mockInterfaceList() { - ArrayList<String> diskInterfaces = new ArrayList<String>( + ArrayList<String> diskInterfaces = new ArrayList<>( Arrays.asList(new String[] { "IDE", "VirtIO", @@ -635,7 +635,7 @@ } private void mockGetForDisk(List<VM> vms) { - Map<Boolean, List<VM>> vmsMap = new HashMap<Boolean, List<VM>>(); + Map<Boolean, List<VM>> vmsMap = new HashMap<>(); vmsMap.put(Boolean.TRUE, vms); when(vmDAO.getForDisk(diskImageGuid, true)).thenReturn(vmsMap); } @@ -725,7 +725,7 @@ StorageDomain storage = new StorageDomain(); storage.setId(Guid.newGuid()); storage.setStorageType(storageType); - diskImage.setStorageIds(new ArrayList<Guid>(Arrays.asList(storage.getId()))); + diskImage.setStorageIds(new ArrayList<>(Arrays.asList(storage.getId()))); return storage; } -- To view, visit http://gerrit.ovirt.org/27768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iece81799898b3ec2fdb383418d8d82f7e3e57a1a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches