Allon Mureinik has uploaded a new change for review. Change subject: core: GetHostListFromExternalProvider test asserts ......................................................................
core: GetHostListFromExternalProvider test asserts Use proper JUnit assertEquals statements instead of Java's asserts. Change-Id: I3a542ca5cb806a931f4606312932d2de22cbf4cf Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/62/27762/1 diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java index 70fabba..392fb6e 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetHostListFromExternalProviderQueryTest.java @@ -50,7 +50,7 @@ doReturn(allHosts).when(getQuery()).getProviderHosts(hostProvider, null); doReturn(existingHosts).when(getQuery()).getExistingHosts(); getQuery().executeQueryCommand(); - assert(getQuery().getQueryReturnValue().getReturnValue().equals(allHosts)); + assertEquals(allHosts, getQuery().getQueryReturnValue().getReturnValue()); } @Test @@ -81,7 +81,7 @@ doReturn(allHosts).when(getQuery()).getProviderHosts(hostProvider, null); doReturn(existingHosts).when(getQuery()).getExistingHosts(); getQuery().executeQueryCommand(); - assert(getQuery().getQueryReturnValue().getReturnValue().equals(allHosts)); + assertEquals(allHosts, getQuery().getQueryReturnValue().getReturnValue()); } @Test -- To view, visit http://gerrit.ovirt.org/27762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3a542ca5cb806a931f4606312932d2de22cbf4cf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches