Yair Zaslavsky has posted comments on this change. Change subject: engine : Refactored gluster volume profile query ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/27468/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeProfileParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeProfileParameters.java: Line 11: public boolean isNfs() { Line 12: return nfs; Line 13: } Line 14: Line 15: public void setNfs(boolean nfs) { why do you need a setter for nfs here? Line 16: this.nfs = nfs; Line 17: } Line 18: Line 19: public GlusterVolumeProfileParameters() { Line 19: public GlusterVolumeProfileParameters() { Line 20: Line 21: } Line 22: public GlusterVolumeProfileParameters(Guid clusterId, Guid volumeId) { Line 23: super(clusterId, volumeId); should be : this( clusterId, volumenId, false); Line 24: this.nfs = false; Line 25: } Line 26: Line 27: public GlusterVolumeProfileParameters(Guid clusterId, Guid volumeId, boolean nfs) { -- To view, visit http://gerrit.ovirt.org/27468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41d80dbb8b6865f67fcadf78baed2a813c423d03 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
