Greg Sheremeta has uploaded a new change for review.

Change subject: webadmin: fixed image alignment in Setup Host Networks
......................................................................

webadmin: fixed image alignment in Setup Host Networks

PatternFly patch caused some network boxes and 'Unassigned' label
to be misaligned in Hosts > Networks Interfaces > Setup Host Network
dialog. Fixed.

Change-Id: I13f677ea622c97de721adb0fbde162e18b792e6b
Signed-off-by: Greg Sheremeta <gsher...@redhat.com>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java
3 files changed, 11 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/27752/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
index c794096..7c78284 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
@@ -101,7 +101,7 @@
             background-color: #CED8DF;
             border-color: #7A8D9A;
             cursor: move;
-            height: 27px;
+            height: 32px;
         }
 
         .nicPanel:HOVER {
@@ -145,6 +145,8 @@
 
         .networkImageBorder {
             border: 1px solid #C5C5C5;
+            width: 18px !important;
+            height: 18px !important;
         }
 
         .emptyPanel {
@@ -154,6 +156,11 @@
             width: 100%;
         }
 
+        .emptyPanelLabel {
+            padding-left: 10px;
+            padding-top: 6px;
+        }
+
         .checkCon {
             width: 100%;
             padding: 5px;
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java
index 2218696..cacce68 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkGroup.java
@@ -15,7 +15,6 @@
 import org.ovirt.engine.ui.webadmin.gin.ClientGinjectorProvider;
 
 import com.google.gwt.dom.client.Element;
-import com.google.gwt.dom.client.Style.Unit;
 import com.google.gwt.event.dom.client.DragDropEventBase;
 import com.google.gwt.event.dom.client.DragEnterEvent;
 import com.google.gwt.event.dom.client.DragEnterHandler;
@@ -88,7 +87,7 @@
         } else {
             SimplePanel emptyPanel = new SimplePanel();
             Label label = new Label(constants.noNetworkAssigned());
-            label.getElement().getStyle().setPadding(10, Unit.PX);
+            label.getElement().addClassName(style.emptyPanelLabel());
             emptyPanel.setWidget(label);
             emptyPanel.setStylePrimaryName(style.emptyPanel());
             table.setWidget(0, 2, emptyPanel);
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java
index 7c05c03..f88038d 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java
@@ -11,6 +11,8 @@
 
     String emptyPanel();
 
+    String emptyPanelLabel();
+
     String groupPanel();
 
     String unassignedNetworksPanel();


-- 
To view, visit http://gerrit.ovirt.org/27752
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I13f677ea622c97de721adb0fbde162e18b792e6b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to