Maor Lipchuk has posted comments on this change. Change subject: core: Detach storage domain when remove Storage Pool. ......................................................................
Patch Set 12: (3 comments) http://gerrit.ovirt.org/#/c/27307/12//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-05-01 16:42:39 +0300 Line 4: Commit: Maor Lipchuk <mlipc...@redhat.com> Line 5: CommitDate: 2014-05-14 03:46:33 +0300 Line 6: Line 7: core: Detach storage domain when remove Storage Pool. > /s/Detach storage domain when remove Storage Pool./Allowing to detach domai too long, added it in the description Line 8: Line 9: Allow to remove storage pool even if there is a Storage Domain which Line 10: contains VMs and disks. Line 11: Line 6: Line 7: core: Detach storage domain when remove Storage Pool. Line 8: Line 9: Allow to remove storage pool even if there is a Storage Domain which Line 10: contains VMs and disks. > /s/VMs and disks/VMs/Templates/Disks Replace the message with your suggestion Line 11: Line 12: Change-Id: I120c6b001a197e65528edb73375b379f76d24cd5 http://gerrit.ovirt.org/#/c/27307/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java: Line 163: connectAllHostToPoolAndDomain(masterDomain); Line 164: Line 165: List<VDS> vdss = getAllRunningVdssInPool(); Line 166: for (StorageDomain storageDomain : storageDomains) { Line 167: detachStorageDomainWithEntities(storageDomain); > this shouldn't happen here for the master storage domain, done Line 168: if (storageDomain.getStorageDomainType() != StorageDomainType.Master) { Line 169: if (!removeDomainFromPool(storageDomain, vdss.get(0))) { Line 170: log.errorFormat("Unable to detach storage domain {0} {1}", Line 171: storageDomain.getStorageName(), -- To view, visit http://gerrit.ovirt.org/27307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I120c6b001a197e65528edb73375b379f76d24cd5 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
