Kobi Ianko has posted comments on this change. Change subject: common: Introduce profiles package & Disk Profile ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27098/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/BaseProfile.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/profiles/BaseProfile.java: Line 19: private static final long serialVersionUID = 1055016330475623255L; Line 20: Line 21: @NotNull(groups = { UpdateEntity.class, RemoveEntity.class }) Line 22: private Guid id; Line 23: @Size(min = 1, max = BusinessEntitiesDefinitions.PROFILE_NAME_SIZE, groups = { CreateEntity.class, BusinessEntitiesDefinitions.PROFILE_NAME_SIZE is missing Line 24: UpdateEntity.class }) Line 25: @ValidName(message = "VALIDATION_NAME_INVALID", groups = { CreateEntity.class, UpdateEntity.class }) Line 26: private String name; Line 27: private Guid qosId; -- To view, visit http://gerrit.ovirt.org/27098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af22277b50554531511002f19046c0051d8ff Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
