Greg Sheremeta has uploaded a new change for review.
Change subject: webadmin: fixed edit icons in Setup Host Network dialog
......................................................................
webadmin: fixed edit icons in Setup Host Network dialog
PatternFly patch caused some weird spacing issues with the edit icons/buttons
in Hosts > Networks Interfaces > Setup Host Network dialog. Fixed.
Change-Id: If85fd9ea6a8b20d91bd88e0d8d736a221dff0c71
Signed-off-by: Greg Sheremeta <gsher...@redhat.com>
---
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java
M packaging/branding/ovirt.brand/patternfly-custom-hacks.css
4 files changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/27708/1
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
index a826332..908011a 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
@@ -136,7 +136,7 @@
}
.actionButtonNetwork {
- padding: 8px;
+ cursor: pointer;
}
.actionButtonBond {
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
index c7af1a4..9fa2675 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
@@ -76,6 +76,8 @@
actionButton.getDownFace().setImage(new
Image(resources.editMouseDown()));
actionButton.setPixelSize(editImage.getWidth(), editImage.getHeight());
actionButton.setVisible(false);
+ actionButton.addStyleName("buttonStyle_pfly_fix"); //$NON-NLS-1$
+ actionButton.addStyleName("nip_actionButton_pfly_fix"); //$NON-NLS-1$
this.item = item;
this.style = style;
diff --git
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java
index 2d52c70..0b5f5dd 100644
---
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java
+++
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java
@@ -19,6 +19,7 @@
public NetworkPanel(LogicalNetworkModel item, NetworkPanelsStyle style,
boolean draggable) {
super(item, style, draggable);
actionButton.setStyleName(style.actionButtonNetwork());
+ actionButton.addStyleName("np_actionButton_pfly_fix"); //$NON-NLS-1$
if (item.isManagement()) {
getElement().addClassName(style.mgmtNetwork());
}
diff --git a/packaging/branding/ovirt.brand/patternfly-custom-hacks.css
b/packaging/branding/ovirt.brand/patternfly-custom-hacks.css
index 92a220b..3b79a3a 100644
--- a/packaging/branding/ovirt.brand/patternfly-custom-hacks.css
+++ b/packaging/branding/ovirt.brand/patternfly-custom-hacks.css
@@ -402,3 +402,18 @@
position: relative !important;
top: 2px !important;
}
+.nip_actionButton_pfly_fix img {
+ left: -2px;
+}
+.np_actionButton_pfly_fix {
+ cursor: pointer;
+ position: relative;
+ top: 1px !important;
+ right: 3px !important;
+}
+.np_actionButton_pfly_fix img {
+ cursor: pointer;
+ position: relative;
+ left: 2px !important;
+ top: -5px !important;
+}
--
To view, visit http://gerrit.ovirt.org/27708
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If85fd9ea6a8b20d91bd88e0d8d736a221dff0c71
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
