Allon Mureinik has posted comments on this change. Change subject: core: add 3.5 support ......................................................................
Patch Set 2: Code-Review+2 (7 comments) Since there are already +1s from Virt, Network and Infra stakeholders, I feel comfortable enough to give +2. Please fix the typo in the commit message before merging though. Also, see a couple of inline comment - they all suggest further improvements, should not be part of THIS patch. http://gerrit.ovirt.org/#/c/27613/2//COMMIT_MSG Commit Message: Line 6: Line 7: core: add 3.5 support Line 8: Line 9: This patch adds 3.5 support in code, tests and DB configuration Line 10: It also creates default 3,5 DC and Cluster and enables to create s/3,5/3.5/ Line 11: new 3.5 DCs and Clusters Line 12: Line 13: Change-Id: Icb0c3ce202789d983cae95b0b1ea4ef0ead73e0d Line 14: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1095258 http://gerrit.ovirt.org/#/c/27613/2/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java File backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java: Line 14: private int minor; Line 15: private int build; Line 16: private int revision; Line 17: Line 18: public static final Version v2_2 = new Version(2, 2); Not part of THIS patch, but shouldn't we get rid of 2.2 already? Line 19: public static final Version v3_0 = new Version(3, 0); Line 20: public static final Version v3_1 = new Version(3, 1); Line 21: public static final Version v3_2 = new Version(3, 2); Line 22: public static final Version v3_3 = new Version(3, 3); http://gerrit.ovirt.org/#/c/27613/2/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 386: select fn_db_add_config_value('MaxNumOfCpuPerSocket','16','3.1'); Line 387: select fn_db_add_config_value('MaxNumOfCpuPerSocket','16','3.2'); Line 388: select fn_db_add_config_value('MaxNumOfCpuPerSocket','16','3.3'); Line 389: select fn_db_add_config_value('MaxNumOfCpuPerSocket','16','3.4'); Line 390: select fn_db_add_config_value('MaxNumOfCpuPerSocket','16','3.5'); Probably not part of this patch - but since it's always the same value, regardless of the version, shouldn't it be collapsed to a single general conf value? Line 391: select fn_db_add_config_value('MaxNumOfVmCpus','64','3.0'); Line 392: select fn_db_add_config_value('MaxNumOfVmCpus','160','3.1'); Line 393: select fn_db_add_config_value('MaxNumOfVmCpus','160','3.2'); Line 394: select fn_db_add_config_value('MaxNumOfVmCpus','160','3.3'); Line 392: select fn_db_add_config_value('MaxNumOfVmCpus','160','3.1'); Line 393: select fn_db_add_config_value('MaxNumOfVmCpus','160','3.2'); Line 394: select fn_db_add_config_value('MaxNumOfVmCpus','160','3.3'); Line 395: select fn_db_add_config_value('MaxNumOfVmCpus','160','3.4'); Line 396: select fn_db_add_config_value('MaxNumOfVmCpus','160','3.5'); Probably not part of this patch - but since it's always the same value, regardless of the version, shouldn't it be collapsed to a single general conf value? Line 397: select fn_db_add_config_value('MaxNumOfVmSockets','16','3.0'); Line 398: select fn_db_add_config_value('MaxNumOfVmSockets','16','3.1'); Line 399: select fn_db_add_config_value('MaxNumOfVmSockets','16','3.2'); Line 400: select fn_db_add_config_value('MaxNumOfVmSockets','16','3.3'); Line 398: select fn_db_add_config_value('MaxNumOfVmSockets','16','3.1'); Line 399: select fn_db_add_config_value('MaxNumOfVmSockets','16','3.2'); Line 400: select fn_db_add_config_value('MaxNumOfVmSockets','16','3.3'); Line 401: select fn_db_add_config_value('MaxNumOfVmSockets','16','3.4'); Line 402: select fn_db_add_config_value('MaxNumOfVmSockets','16','3.5'); Probably not part of this patch - but since it's always the same value, regardless of the version, shouldn't it be collapsed to a single general conf value? Line 403: select fn_db_add_config_value('MaxRerunVmOnVdsCount','3','general'); Line 404: select fn_db_add_config_value('MaxStorageVdsDelayCheckSec','5','general'); Line 405: select fn_db_add_config_value('MaxStorageVdsTimeoutCheckSec','30','general'); Line 406: select fn_db_add_config_value('MaxVdsMemOverCommit','200','general'); Line 542: select fn_db_add_config_value('UserDefinedVMProperties','','3.1'); Line 543: select fn_db_add_config_value('UserDefinedVMProperties','','3.2'); Line 544: select fn_db_add_config_value('UserDefinedVMProperties','','3.3'); Line 545: select fn_db_add_config_value('UserDefinedVMProperties','','3.4'); Line 546: select fn_db_add_config_value('UserDefinedVMProperties','','3.5'); Probably not part of this patch - but since it's always the same value, regardless of the version, shouldn't it be collapsed to a single general conf value? Line 547: select fn_db_add_config_value('UserRefreshRate','3600','general'); Line 548: select fn_db_add_config_value('UserSessionTimeOutInterval','30','general'); Line 549: select fn_db_add_config_value('UtilizationThresholdInPercent','80','general'); Line 550: select fn_db_add_config_value('ValidNumOfMonitors','1,2,4','general'); Line 635: select fn_db_add_config_value('CustomDeviceProperties', '', '3.1'); Line 636: select fn_db_add_config_value('CustomDeviceProperties', '', '3.2'); Line 637: select fn_db_add_config_value('CustomDeviceProperties', '', '3.3'); Line 638: select fn_db_add_config_value('CustomDeviceProperties', '', '3.4'); Line 639: select fn_db_add_config_value('CustomDeviceProperties', '', '3.5'); Probably not part of this patch - but since it's always the same value, regardless of the version, shouldn't it be collapsed to a single general conf value? Line 640: Line 641: -- Network Custom Properties Line 642: select fn_db_add_config_value('NetworkCustomPropertiesSupported', 'false', '3.0'); Line 643: select fn_db_add_config_value('NetworkCustomPropertiesSupported', 'false', '3.1'); -- To view, visit http://gerrit.ovirt.org/27613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb0c3ce202789d983cae95b0b1ea4ef0ead73e0d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
