Xiaolei Shi has posted comments on this change. Change subject: db: Numa support database implementation ......................................................................
Patch Set 28: (1 comment) http://gerrit.ovirt.org/#/c/26996/28/packaging/dbscripts/upgrade/03_05_0430_add_numa_tables_and_columns.sql File packaging/dbscripts/upgrade/03_05_0430_add_numa_tables_and_columns.sql: Line 85: Create or replace FUNCTION __temp_add_numa_columns() returns void Line 86: AS $procedure$ Line 87: BEGIN Line 88: -- Add columns in table vm_static Line 89: PERFORM fn_db_add_column('vm_static', 'numatune_mode', 'varchar(20)'); > please change this field to smallint with default 0. the value of this field is needed by libvirt. If change to smallint, we need to do a type mapping. I think this type transform is redundant. Line 90: Line 91: -- Add columns in table vds_dynamic Line 92: PERFORM fn_db_add_column('vds_dynamic', 'auto_numa_balancing', 'smallint'); Line 93: PERFORM fn_db_add_column('vds_dynamic', 'is_numa_supported', 'boolean'); -- To view, visit http://gerrit.ovirt.org/26996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2507c084aa214bcfb65e860b11ed7dcf02af50cc Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
