Allon Mureinik has posted comments on this change. Change subject: core, webadmin: report QEMU live snapshot support ......................................................................
Patch Set 1: Code-Review-1 (2 comments) There's a bug in VdsDynamic#equals - see inline. Also missing - database/DAO implementation. http://gerrit.ovirt.org/#/c/27677/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java: Line 87: private String iScsiInitiatorName; Line 88: Line 89: private KdumpStatus kdumpStatus; Line 90: Line 91: private Boolean liveSnapshotSupport; Why use a Boolean and not a boolean? Can this ever be null? According to the code in VdsBrokerObjectsBuilder, it's jsut assumed to be true if it isn't reported by VDSM. Line 92: Line 93: private VdsTransparentHugePagesState transparentHugePagesState; Line 94: Line 95: @Size(max = BusinessEntitiesDefinitions.GENERAL_NAME_SIZE) Line 776: && ObjectUtils.objectsEqual(selinuxEnforceMode, other.selinuxEnforceMode) Line 777: && ObjectUtils.objectsEqual(numaNodeList, other.numaNodeList) Line 778: && autoNumaBalancing.getValue() == other.autoNumaBalancing.getValue() Line 779: && numaSupport == other.numaSupport); Line 780: && liveSnapshotSupport == other.liveSnapshotSupport; liveSnapshotSupport is a Boolean object. There's no guarantee that two Boolean objects with the same value will indeed be the same instance. You should use ObjectUtils.objectsEqual(liveSnapshotSupport, other.liveSnapshotSupport). Line 781: } Line 782: -- To view, visit http://gerrit.ovirt.org/27677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2a34967eeeefcaabf2fad21192b7045f9ecc07e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
