Roy Golan has uploaded a new change for review.
Change subject: core: VURTI - don't open a TX to save numa changes
......................................................................
core: VURTI - don't open a TX to save numa changes
there is no real benefit for a saving all numa changes in TX here.
the only thing that is being done there is db calls.
Change-Id: Ieb55254d070bb2205e368220f611c2a373ff7e42
Signed-off-by: Roy Golan <rgo...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
1 file changed, 9 insertions(+), 20 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/27673/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
index e90471a..e85b0f8 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
@@ -34,7 +34,6 @@
import org.ovirt.engine.core.common.vdscommands.VDSReturnValue;
import
org.ovirt.engine.core.common.vdscommands.VdsIdAndVdsVDSCommandParametersBase;
import org.ovirt.engine.core.compat.Guid;
-import org.ovirt.engine.core.compat.TransactionScopeOption;
import org.ovirt.engine.core.compat.Version;
import org.ovirt.engine.core.dal.dbbroker.DbFacade;
import org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector;
@@ -48,8 +47,6 @@
import org.ovirt.engine.core.utils.timer.OnTimerMethodAnnotation;
import org.ovirt.engine.core.utils.timer.SchedulerUtil;
import org.ovirt.engine.core.utils.timer.SchedulerUtilQuartzImpl;
-import org.ovirt.engine.core.utils.transaction.TransactionMethod;
-import org.ovirt.engine.core.utils.transaction.TransactionSupport;
import org.ovirt.engine.core.vdsbroker.irsbroker.IRSErrorException;
import org.ovirt.engine.core.vdsbroker.irsbroker.IrsBrokerCommand;
import
org.ovirt.engine.core.vdsbroker.vdsbroker.CollectVdsNetworkDataVDSCommand;
@@ -412,23 +409,15 @@
numaNodesToRemove.add(node.getId());
}
- //The database operation should be in one transaction
- TransactionSupport.executeInScope(TransactionScopeOption.Required,
- new TransactionMethod<Void>() {
- @Override
- public Void runInTransaction() {
- if (!numaNodesToRemove.isEmpty()){
-
DbFacade.getInstance().getVdsNumaNodeDAO().massRemoveNumaNodeByNumaNodeId(numaNodesToRemove);
- }
- if (!numaNodesToUpdate.isEmpty()){
-
DbFacade.getInstance().getVdsNumaNodeDAO().massUpdateNumaNode(numaNodesToUpdate);
- }
- if (!numaNodesToSave.isEmpty()){
-
DbFacade.getInstance().getVdsNumaNodeDAO().massSaveNumaNode(numaNodesToSave,
vds.getId(), null);
- }
- return null;
- }
- });
+ if (!numaNodesToRemove.isEmpty()) {
+
DbFacade.getInstance().getVdsNumaNodeDAO().massRemoveNumaNodeByNumaNodeId(numaNodesToRemove);
+ }
+ if (!numaNodesToUpdate.isEmpty()) {
+
DbFacade.getInstance().getVdsNumaNodeDAO().massUpdateNumaNode(numaNodesToUpdate);
+ }
+ if (!numaNodesToSave.isEmpty()) {
+
DbFacade.getInstance().getVdsNumaNodeDAO().massSaveNumaNode(numaNodesToSave,
vds.getId(), null);
+ }
}
public void refreshHost(VDS vds) {
--
To view, visit http://gerrit.ovirt.org/27673
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb55254d070bb2205e368220f611c2a373ff7e42
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
