Sandro Bonazzola has posted comments on this change. Change subject: reports: moved to using only ce edition dashboards in webadmin ......................................................................
Patch Set 4: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/27644/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/engine.py: Line 56: Line 57: with open( Line 58: oreportscons.FileLocations.OVIRT_ENGINE_REPORTS_UI, Line 59: "r", Line 60: ) as content: I would prefer something like "template" instead of "content" Line 61: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 62: filetransaction.FileTransaction( Line 63: name=os.path.join( Line 64: osetupcons.FileLocations.OVIRT_ENGINE_LOCALSTATEDIR, -- To view, visit http://gerrit.ovirt.org/27644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c62986ace8f7b04a038d4b0c461580639335bed Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
