Yaniv Dary has posted comments on this change. Change subject: history: Updated calculation of cpu usage ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/27559/4/packaging/dbscripts/create_dwh_views.sql File packaging/dbscripts/create_dwh_views.sql: Line 268: c.vm_guid as vm_id, Line 269: cast(b.status as smallint) as vm_status, Line 270: cast(c.usage_cpu_percent as smallint) as cpu_usage_percent, Line 271: cast(c.usage_mem_percent as smallint) as memory_usage_percent, Line 272: cast(c.cpu_sys / (vm_static.cpu_per_socket * vm_static.num_of_sockets) as smallint ) should be no space after 'smallint'. Please add '()' around calculated expression. Line 273: as system_cpu_usage_percent, Line 274: cast(c.cpu_user / (vm_static.cpu_per_socket * vm_static.num_of_sockets) as smallint ) Line 275: as user_cpu_usage_percent, Line 276: c.disks_usage, -- To view, visit http://gerrit.ovirt.org/27559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfae05895d8450e6d5f450fbf2a9e934e65a5785 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
