Maor Lipchuk has posted comments on this change. Change subject: core: Add snapshot to the OVF generation ......................................................................
Patch Set 19: (2 comments) http://gerrit.ovirt.org/#/c/25947/19/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java: Line 495: } Line 496: return super.getAuditLogTypeValue(); Line 497: } Line 498: Line 499: protected boolean updateVmImSpm() { > not related to patch - but, s/updateVmImSpm/updateVmInSpm done Line 500: Map<Guid, KeyValuePairCompat<String, List<Guid>>> metaDictionary = Line 501: new HashMap<Guid, KeyValuePairCompat<String, List<Guid>>>(); Line 502: OvfDataUpdater.getInstance().loadVmData(getVm()); Line 503: OvfDataUpdater.getInstance().buildMetadataDictionaryForVm(getVm(), http://gerrit.ovirt.org/#/c/25947/19/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java: Line 417: * Returns true if all snapshots have a valid status to use in the OVF. Line 418: */ Line 419: protected boolean verifySnapshotsStatus(List<Snapshot> snapshots) { Line 420: for (Snapshot snapshot : snapshots) { Line 421: if (snapshot.getStatus() != SnapshotStatus.OK && snapshot.getStatus() != SnapshotStatus.BROKEN) { > not sure why broken is considered valid - btu, note the broken status might done Line 422: return false; Line 423: } Line 424: } Line 425: return true; -- To view, visit http://gerrit.ovirt.org/25947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ba05c2e362fb9b22d6b4fb5a14698ad99d7bd1e Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
