Kobi Ianko has posted comments on this change. Change subject: Adding support in CPU monitoring ......................................................................
Patch Set 9: (4 comments) http://gerrit.ovirt.org/#/c/27240/9/mom/Collectors/Collector.py File mom/Collectors/Collector.py: Line 138: return int(m.group(1)) Line 139: else: Line 140: return None Line 141: Line 142: def count_int(regex, src): > count_occurrences might be a better name here.. Done Line 143: """ Line 144: Parse a body of text according to the provided regular expression and return Line 145: the count of matches as an integer. Line 146: """ http://gerrit.ovirt.org/#/c/27240/9/mom/HypervisorInterfaces/libvirtInterface.py File mom/HypervisorInterfaces/libvirtInterface.py: Line 249: domain = self._getDomainFromUUID(uuid) Line 250: Line 251: """ Line 252: Get the user selection for vcpuLimit from the metadata Line 253: """ > Please convert those to Python comments using #. This evaluates to string w Done Line 254: metadataCpuLimit = domain.getMetadata(2,'http://ovirt.org/param/vcpu_limit',0) Line 255: Line 256: if metadataCpuLimit: Line 257: ret['vcpu_user_limit'] = metadataCpuLimit Line 289: self.logger.warn("Error while ballooning guest:%i", name) Line 290: Line 291: def setVmCpuTune(self, uuid, quota, period): Line 292: dom = self._getDomainFromUUID(uuid) Line 293: dom.setSchedulerParameters({ 'vcpu_quota': quota, 'vcpu_period': period}) > Exception handling? Done Line 294: Line 295: def ksmTune(self, tuningParams): Line 296: def write_value(fname, value): Line 297: try: http://gerrit.ovirt.org/#/c/27240/9/mom/HypervisorInterfaces/vdsmInterface.py File mom/HypervisorInterfaces/vdsmInterface.py: Line 202: response = vm.setCpuTuneQuota(quota) Line 203: self._check_status(response) Line 204: except vdsmException, e: Line 205: e.handle_exception() Line 206: try: > whitespaces Done Line 207: response = vm.setCpuTunePeriod(period) Line 208: self._check_status(response) Line 209: except vdsmException, e: Line 210: e.handle_exception() -- To view, visit http://gerrit.ovirt.org/27240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31428499ae7b34cafa3eacf5ca0d7a39eabe23ec Gerrit-PatchSet: 9 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
