Martin Mucha has posted comments on this change. Change subject: core,userportal,webadmin: added singular variant for messages. ......................................................................
Patch Set 2: (6 comments) answers. http://gerrit.ovirt.org/#/c/25736/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/RemoveProviderCommand.java: Line 111: : new ValidationResult(providerNetworkUsedValidationMessage(networksInUse.size()), Line 112: ReplacementUtils.replaceWithNameable("NETWORK_NAMES", networksInUse)); Line 113: } Line 114: Line 115: public VdcBllMessages providerNetworkUsedValidationMessage(int numberOfNetworks) { > 1. A method name should start with a verb (like get...) Done Line 116: boolean singular = numberOfNetworks == 1; Line 117: return singular ? VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_NETWORKS_USED_ONCE : VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_NETWORKS_USED_MULTIPLE_TIMES; Line 118: } Line 119: Line 113: } Line 114: Line 115: public VdcBllMessages providerNetworkUsedValidationMessage(int numberOfNetworks) { Line 116: boolean singular = numberOfNetworks == 1; Line 117: return singular ? VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_NETWORKS_USED_ONCE : VdcBllMessages.ACTION_TYPE_FAILED_PROVIDER_NETWORKS_USED_MULTIPLE_TIMES; > 1. Please avoid such long lines. That page http://www.ovirt.org/Building_oV Done Line 118: } Line 119: Line 120: protected NetworkDao getNetworkDao() { Line 121: return DbFacade.getInstance().getNetworkDao(); http://gerrit.ovirt.org/#/c/25736/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java: Line 155: replacements.add(entitiesReplacement.name()); Line 156: return new ValidationResult(networkInUseValidationMessage(entities.size()), replacements); Line 157: } Line 158: Line 159: private VdcBllMessages networkInUseValidationMessage(int numberOfEntities) { > A method name should start with a verb (like get...) Done Line 160: boolean singular = numberOfEntities == 1; Line 161: return singular ? VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_IN_ONE_USE : VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_IN_MANY_USES; Line 162: } Line 163: Line 157: } Line 158: Line 159: private VdcBllMessages networkInUseValidationMessage(int numberOfEntities) { Line 160: boolean singular = numberOfEntities == 1; Line 161: return singular ? VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_IN_ONE_USE : VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_IN_MANY_USES; > 1. Please avoid such long lines. That page http://www.ovirt.org/Building_oV Done Line 162: } Line 163: Line 164: /** Line 165: * @return An error iff the network is in use by any VMs. http://gerrit.ovirt.org/#/c/25736/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java: Line 97: replacements.add(entitiesReplacement.name()); Line 98: return new ValidationResult(vNicProfileInUseValidationMessage(entities.size()), replacements); Line 99: } Line 100: Line 101: private VdcBllMessages vNicProfileInUseValidationMessage(int numberOfEntities) { > A method name should start with a verb (like get...) Done Line 102: boolean singular = numberOfEntities == 1; Line 103: return singular ? VdcBllMessages.ACTION_TYPE_FAILED_VNIC_PROFILE_IN_ONE_USE : VdcBllMessages.ACTION_TYPE_FAILED_VNIC_PROFILE_IN_MANY_USES; Line 104: } Line 105: Line 99: } Line 100: Line 101: private VdcBllMessages vNicProfileInUseValidationMessage(int numberOfEntities) { Line 102: boolean singular = numberOfEntities == 1; Line 103: return singular ? VdcBllMessages.ACTION_TYPE_FAILED_VNIC_PROFILE_IN_ONE_USE : VdcBllMessages.ACTION_TYPE_FAILED_VNIC_PROFILE_IN_MANY_USES; > 1. Please avoid such long lines. That page http://www.ovirt.org/Building_oV Done Line 104: } Line 105: Line 106: public ValidationResult portMirroringNotChangedIfUsedByVms() { Line 107: if (vnicProfile.isPortMirroring() == getOldVnicProfile().isPortMirroring()) { -- To view, visit http://gerrit.ovirt.org/25736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2410b2c75380a78ffc24d142987e684182bf5dc9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
