Shirly Radco has posted comments on this change. Change subject: history: sync users data for user usage tables ......................................................................
Patch Set 11: (4 comments) http://gerrit.ovirt.org/#/c/27338/11/etl_export/src/ovirt_engine_dwh/aggregationtohourly_3_5/AggregationToHourly.java File etl_export/src/ovirt_engine_dwh/aggregationtohourly_3_5/AggregationToHourly.java: Line 23773 Line 23774 Line 23775 Line 23776 Line 23777 > You removed this column and now you don't reference it in group. What will Done http://gerrit.ovirt.org/#/c/27338/11/packaging/dbscripts/create_views_3_4.sql File packaging/dbscripts/create_views_3_4.sql: Line 490: a.time_zone as time_zone, Line 491: a.vm_pool_id, Line 492: a.vm_pool_name, Line 493: a.created_by_user_id, Line 494: COALESCE(users.username, a.created_by_user_name) as created_by_user_name, > Please check types are maintained. Checked and character varying is allies to varchar. and it is also ansi. The values of "user name" are varchar(255) and in the users_detailes_history its 'character varying. I dont think there is an issue here. What do you think? Line 495: a.cluster_configuration_version as cluster_configuration_version, Line 496: a.default_host_configuration_version as default_host_configuration_version, Line 497: a.create_date as create_date, Line 498: a.update_date as update_date http://gerrit.ovirt.org/#/c/27338/11/packaging/dbscripts/upgrade/03_05_0030_add_users_history_table.sql File packaging/dbscripts/upgrade/03_05_0030_add_users_history_table.sql: Line 12: active boolean NOT NULL DEFAULT false, Line 13: create_date TIMESTAMP WITH TIME ZONE NOT NULL, Line 14: update_date TIMESTAMP WITH TIME ZONE, Line 15: delete_date TIMESTAMP WITH TIME ZONE Line 16: ) WITH OIDS; > please change the syntax to standard pl\sql checked and character varying in ansi for varchar. Line 17: Line 18: SELECT fn_db_add_column('vm_samples_history', 'current_user_id', 'UUID'); Line 19: Line 20: ALTER TABLE vm_samples_history Line 42: SELECT fn_db_add_column('statistics_vms_users_usage_daily', 'user_id', 'UUID'); Line 43: Line 44: ALTER TABLE statistics_vms_users_usage_daily Line 45: ADD CONSTRAINT statistics_vms_users_usage_daily_user_id_fkey FOREIGN KEY (user_id) Line 46: REFERENCES users_details_history (user_id) MATCH SIMPLE; > Please add comment to why we don't add this to vm_configuration Done -- To view, visit http://gerrit.ovirt.org/27338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id236a3112947e00a58175f0361d44afda692b894 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
