Tomas Jelinek has posted comments on this change. Change subject: webadmin: edit running vm ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/27369/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 649: public static void getVmNextRunConfiguration(AsyncQuery aQuery, Guid vmId) { Line 650: aQuery.converterCallback = new IAsyncConverter() { Line 651: @Override Line 652: public Object Convert(Object source, AsyncQuery _asyncQuery) Line 653: { I know that the converter callback is implemented like this in lots of places but it is really not needed if it does nothing. So please remove the converter callback if you do not need any logic in it. Line 654: return source; Line 655: } Line 656: }; Line 657: Frontend.getInstance().runQuery(VdcQueryType.GetVmNextRunConfiguration, new IdQueryParameters(vmId), aQuery); -- To view, visit http://gerrit.ovirt.org/27369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica093428d180fb280d53fd40dc5a4109b2aa842e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
